IRC logs

20150813

• 04:37:31 <pedda> hi there
• 04:44:44 <k4mi> Hey, there. Got a small problem with f:image. I got a list of high-resolution images which are getting resized with f:image. The problem is some are getting perfectly processed, but some are still refering to the original image.
• 04:45:48 <k4mi> Snippet looks like this: <f:image image="{imageObj}" width="100" height="100c" />
• 04:54:09 <pedda> thge images won't get resized if their dimensions match 100 x 100
• 04:55:04 <pedda> see if this is the case
• 04:58:29 <pedda> what might cause an editAction of my custom extbase extension to display "cached/old" values?
• 04:58:43 <pedda> let's say i have a record A with title set to myTitle
• 04:59:08 <k4mi> Hm I am getting close to the problem it seems i have a problem with empty spaces in the image name
• 04:59:21 <k4mi> I guess a charset problem
• 04:59:35 <pedda> if this record is edited and title is set to myNewTitle i am redirected to the listAction which renders the new title
• 05:00:06 <pedda> but if i edit the record again, i see the old title ... i need to refresh my browser to see the new title in the edit view
• 05:00:10 <pedda> is this cache?
• 05:00:34 <pedda> k4mi this is not only your problem.. rather a general editor issue
• 05:01:08 <pedda> you can take care of weird characters in image/file names, but you could also advise your editors to take care on their own
• 05:01:15 <pedda> depends on the project's budget
• 05:01:27 <pedda> as there can be a lot to sanitize
• 05:02:09 <pedda> üöä..á..ñ even ! occured to me
• 05:02:10 <k4mi> Shouldnt be to many, but thanks for the advice
• 05:02:28 <pedda> KISS: hey mr editor never ever use those characters
• 05:02:48 <k4mi> üöä stored in the right charset works.. but it seems you should rather avoid it
• 05:02:59 <pedda> yepp
• 05:03:14 <pedda> you never now which third party module/plugin/lib can't deal with it
• 05:03:38 <pedda> and if you got that far for a year or so.. renaming all those files from the beginning to now can be a pain in the ass
• 05:03:48 <pedda> especially if you're dealing with FAL and such
• 05:04:21 <pedda> if you need to rename the files because lib XYZ is mandatory and can't be replaced by sth. else
• 09:20:34 <mneuhaus> god i hate translating stuff in fluid
• 09:20:45 <mneuhaus> feels soo stupidly tedious
• 15:47:49 <mneuhaus> man, vhs has quite some condition viewhelpers these days ^^ and almost all of them are fucked up the the compile static change in 7.3
• 17:46:43 <NamelessCoder> that's a big one, mneuhaus!
• 17:47:51 <NamelessCoder> needs a rebase ;)
• 17:52:21 <mneuhaus> there you go ;)
• 17:52:43 <mneuhaus> sadly still 2 broken
• 17:53:47 <mneuhaus> i mean, i have them working locally, but i needed to make the trait static for that, which has side-effects on all the other non condition viewhelpers using that trait
• 17:54:25 <NamelessCoder> https://github.com/FluidTYPO3/vhs/pull/894/files#diff-af35b327e3a76b27a092ced8a5a3f32bL40 you are sure the inherited property is now "protected" in all our supported TYPO3 versions including 6.2?
• 17:54:30 <NamelessCoder> I'm not ;)
• 17:55:53 <NamelessCoder> generally speaking, a lot of classes can be imported from FQN usages
• 17:55:58 <NamelessCoder> renderingcontext etc.
• 17:56:30 <mneuhaus> not sure what you mean about the protected property
• 17:56:49 <NamelessCoder> $this->reflectionService is private on 6.2, that's why we inject it
• 17:56:50 <mneuhaus> sure, i can clean up some stuff as well :)
• 17:57:04 <NamelessCoder> we simply have to, because we can't use the private of the parent class
• 17:57:15 <mneuhaus> i don't use the private one
• 17:57:21 <mneuhaus> i fetch one through the object manager
• 17:57:28 <mneuhaus> since were in a static context
• 17:57:43 <mneuhaus> line 70+71
• 17:57:46 <NamelessCoder> oh... that's even more costly ;)
• 17:58:02 <mneuhaus> do you have another solution?
• 17:58:20 <mneuhaus> can't access $this from there anymore
• 17:58:38 <NamelessCoder> hmm, this reflection crap...
• 17:59:00 <mneuhaus> i know that's not a pretty solution, but it was the only one i could think of so far
• 17:59:06 <NamelessCoder> you didn't write it, not blaming you ;)
• 17:59:51 <NamelessCoder> at the very least you need to store "protected static $reflectionService" and check if it exists, if not, create it. That should avoid all the costly objectmanager stuff (and it is VERY costly)
• 18:00:29 <mneuhaus> yep, that sounds def better ^^
• 18:00:56 <NamelessCoder> luckily we don't have a lot of places where these types of services are implemented!
• 18:01:28 <mneuhaus> aside from a pageSelect in the hasSubpage and isChildpage i didn't see similar issues
• 18:01:47 <NamelessCoder> consciously tried to avoid injections ;)
• 18:01:54 <mneuhaus> :)
• 18:02:05 <NamelessCoder> btw I'm thinking about how to solve your "creates new variableprovider" thing
• 18:02:14 <mneuhaus> quite some viewhelpers got a bit cleaner with those changes that needed to be done :)
• 18:02:20 <mneuhaus> hehe :)
• 18:02:25 <NamelessCoder> I'm thinking about a "reset()" or "clear()" method on variableprovider + interface
• 18:02:51 <NamelessCoder> so the instance can be cloned and that method can be called
• 18:03:13 <NamelessCoder> alternatively the variableprovider can be given a method that returns a fresh variableprovider or an instance of itself
• 18:03:36 <NamelessCoder> (so that all this cloning thing becomes an internal decision in your variableprovider only)
• 18:03:44 <mneuhaus> did you see my message about the behavior of partial rendering?
• 18:03:50 <NamelessCoder> the default variableprovider would then simply create a new instance
• 18:04:00 <NamelessCoder> just in case, please repeat it
• 18:04:18 <mneuhaus> "my" variableProvider gets thrown away and replaced by a StandardVariableProvider when it renders a partial
• 18:05:05 <NamelessCoder> yep that's the issue I want to solve ;)
• 18:05:20 <mneuhaus> https://github.com/NamelessCoder/TYPO3.Fluid/blob/master/src/View/AbstractTemplateView.php#L304
• 18:05:23 <NamelessCoder> by either cloning the existing or asking the existing variableprovider for a "new" instance, that should do it
• 18:05:24 <mneuhaus> ah, ok :)
• 18:05:37 <mneuhaus> https://github.com/NamelessCoder/TYPO3.Fluid/blob/master/src/View/AbstractTemplateView.php#L304
• 18:06:12 <NamelessCoder> btw you see my trick with letting it inherit all variables if the arguments array is not specified? ;)
• 18:06:13 <mneuhaus> still not really sure if a variableprovider is the right place for that logic, to be honest
• 18:06:41 <mneuhaus> no, didn't see that
• 18:06:58 <mneuhaus> or didn't realize/look for it ^^
• 18:07:17 <NamelessCoder> $renderingContext->setVariableProvider($renderingContext->getVariableProvider()->getFreshInstanceForVariables($variables ? $variables : $inherited));
• 18:07:22 <NamelessCoder> something like that
• 18:08:05 <NamelessCoder> ->getNewProviderForVariables() or whatever
• 18:08:09 <mneuhaus> ah, you just give it the provider itself, since it's emulating an array anyway ^^
• 18:08:17 <NamelessCoder> yeah
• 18:08:23 <NamelessCoder> it doesn't care :)
• 18:08:23 <mneuhaus> :)
• 18:08:26 <mneuhaus> why not ^^
• 18:08:41 <NamelessCoder> fun code :)
• 18:09:24 <mneuhaus> https://github.com/NamelessCoder/TYPO3.Fluid/blob/master/src/View/AbstractTemplateView.php#L367
• 18:09:41 <mneuhaus> got pagination + limits working
• 18:09:53 <mneuhaus> with a Query + QueryResult though
• 18:12:59 <NamelessCoder> I have to show you something. Shameless bragging :) http://i.imgur.com/XCfxZZQ.jpg - that tiny little thing on the right is my old 27" thunderbolt display...
• 18:13:20 <mneuhaus> grr ^^
• 18:13:45 <mneuhaus> nice :)
• 18:13:57 <NamelessCoder> it is *sick*. So much resolution...
• 18:14:01 <mneuhaus> ^^
• 18:14:38 <mneuhaus> now imagine a oculus with a "infinite" desktop? ^^
• 18:15:08 <mneuhaus> but that really looks quite sweet :) you got my envy :)
• 18:15:32 <mneuhaus> oh, a mac pro?
• 18:15:43 <mneuhaus> i mean a mac trash? ^^
• 18:17:57 <mneuhaus> phew, i'm done. gotta grab some sleep :)
• 18:18:37 <mneuhaus> had to take over a second unplanned project because a dev of the agency hurt his hand ^^
• 18:19:19 <mneuhaus> good night :)
• 18:19:20 <NamelessCoder> nite, sleep tight!
• 18:19:26 <NamelessCoder> yep it's a trash can mac :)