IRC logs

20140701

• 08:25:19 <mrboe> good morning - back again
• 08:44:01 <feelx> moring^^
• 08:44:11 <feelx> morning ... still not awake
• 08:51:00 <bjo3rn> morning
• 11:54:01 <bjo3rn> it seems everyone is still flashed by that spectacular soccer match last night...
• 11:59:33 <BenjaminR> OMG
• 11:59:48 <BenjaminR> crazy match
• 15:35:25 <andreaswolf> hi
• 15:35:44 <andreaswolf> I've got a problem with Flux on TYPO3 6.2
• 15:36:17 <andreaswolf> copying an element from a Flux element does not work – the element is copied, but adjusting the colPos/tx_flux_column/tx_flux_parent values fails
• 15:36:50 <bjo3rn> hi andreaswolf see https://github.com/FluidTYPO3/flux/pull/609
• 15:36:53 <bjo3rn> ^^
• 15:37:12 <bjo3rn> is this your issue?
• 15:37:21 <andreaswolf> I'm unsure if that's a bug in Flux or a misconfiguration in the installation (I did not set it up, it's a client's installation)
• 15:37:33 <andreaswolf> nope, not from the description
• 15:37:45 <andreaswolf> would have to try this
• 15:37:49 <bjo3rn> ok. .oO
• 15:37:51 <andreaswolf> but I'm pretty sure it's not
• 15:38:17 <bjo3rn> what do you mean by 'adjusting the values fails'?
• 15:38:18 <andreaswolf> my problem is the other way round: I try to copy from a Fluidcontent column to the page itself, but colPos and tx_flux_parent are not cleared
• 15:38:25 <bjo3rn> ok
• 15:38:43 <bjo3rn> I'll try to reproduce
• 15:38:50 <andreaswolf> and if I copy inside the Fluidcontent element, the column is adjusted correctly, but tx_flux_parent is set to 0
• 15:39:07 <xaver> bjo3rn: https://github.com/FluidTYPO3/flux/issues/573 last entry
• 15:39:07 <andreaswolf> I tracked it down to EXT:flux/ContentService::afterPaste()
• 15:40:13 <andreaswolf> I also started writing functional tests, they also did not yield the correct values
• 15:40:50 <andreaswolf> the thing is that afterPaste() is *really* ugly IMHO, values are overwritten multiple times, it's unclear what part of the code does what and is called in which situation
• 15:42:27 <bjo3rn> oh, yes. it is not the nicest to read
• 15:43:10 <andreaswolf> is there any reason why Yoda notation is used for "not equal" comparisons?
• 15:43:18 <andreaswolf> that makes some parts really hard to read
• 15:43:37 <bjo3rn> Claus made the CGL
• 15:43:40 <andreaswolf> and with $parentUid > 0 there's nothing that could go wrong, as opposed to $parentUid == 0 vs. $parentUid = 0
• 15:43:43 <andreaswolf> ok…
• 15:44:31 <andreaswolf> as said, it's justified to do it that way for equality comparisons, but I don't see any reason for unequality comparisons
• 15:44:43 <andreaswolf> and a huge potential for bugs…
• 17:17:04 <andreaswolf> I have put my functional tests on Github: https://gist.github.com/andreaswolf/524ccdf5febae59fc147
• 17:17:14 <andreaswolf> the first one works, the other three are broken
• 17:17:44 <andreaswolf> I'm pretty sure that the tests are correct, but I'd appreciate if anyone with deeper knowledge of Flux could have a look
• 18:18:00 <xaver> thx andreaswolf
• 18:27:45 <andreaswolf> I added some more tests and basically re-implemented afterPaste() now
• 18:28:07 <andreaswolf> tests pass even with a nested structure (copying a Fluidcontent element with content in it)
• 18:28:16 <andreaswolf> didn't test the sorting however, that is my next task
• 18:30:43 <bjo3rn> sounds really good andreaswolf
• 18:31:43 <bjo3rn> thanks for your efforts
• 19:39:12 <soee> is there increment vh ?
• 19:52:27 <xaver> soee: why?
• 19:52:37 <xaver> what you try todo?
• 19:54:01 <soee> xaver: need to use counter, anyway i did it liek this:
• 19:54:03 <soee> {v:variable.set(name : 'counter', value : '{v:math.sum(a : counter, b : 1)}')}
• 19:54:57 <xaver> you have a iteration in for
• 19:56:07 <soee> xaver: yes but i need to skip some elements and need seond counter
• 19:59:00 <xaver> {counter -> v:math.sum( b : 1) -> v:variable.set(name : 'counter' )} something like this?